-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jsapi update ci #2480
Jsapi update ci #2480
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me too :)
Perhaps we could convert the deploy
job in a new configuration of the build-pack-test
job, called deploy
, in this way it isn't necessary to upload/download artifacts. What do you think?
Does the deploy
job need to be run for pull_request
events also? If not, we need to move the entire job in a new yml
file.
The thing is, though it is called "deploy" it also does linting for js, which is also useful on PRs. But you are probably right, that this should be a configuration of the other job :) Will refactor it. |
I see, so let's convert it in a configuration :) |
c1e719f
to
7d5ad4d
Compare
511b2f8
to
498469d
Compare
I've decided to add the Additionally I also fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with it, @Luni-4 do you agree?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just two nits :)
498469d
to
c9e7f8c
Compare
abd07ec
to
0ca69e2
Compare
0ca69e2
to
40dcef5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me now, thanks!
Thanks for the review :P |
Thanks to you for your work! :P |
This PR has two purposes:
rav1e_js/www/
Changes
Upload artifact 'rav1e_js-pkg'wasm-pack test --headless --firefox